-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(libsinsp/test): use correct iterator type in plugin tests #1987
fix(libsinsp/test): use correct iterator type in plugin tests #1987
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
Perf diff from master - unit tests
Perf diff from master - scap file
Heap diff from master - unit tests
Heap diff from master - scap file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow great catch!
/approve
LGTM label has been added. Git tree hash: 6a1f6f79058e7f063c504fde99683edf28aeb708
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1987 +/- ##
========================================
Coverage 50.98% 50.98%
========================================
Files 310 310
Lines 39612 39612
Branches 17793 17482 -311
========================================
Hits 20197 20197
+ Misses 14350 14335 -15
- Partials 5065 5080 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
It is incorrect to do
something.find("...") != something_else.end()
. Some debug versions will error on this. Fix this in tests.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: