-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(tests): move some scap files under the scap file test suite #2001
cleanup(tests): move some scap files under the scap file test suite #2001
Conversation
Please double check driver/API_VERSION file. See versioning. /hold |
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
8b18e21
to
a828ecd
Compare
@@ -2,3 +2,5 @@ | |||
|
|||
// Absolute path to the scap files dir | |||
#define LIBSINSP_TEST_SCAP_FILES_DIR "${CMAKE_BINARY_DIR}/scap_files/" | |||
|
|||
#define LIBSINSP_TMP_TEST_SCAP_FILES_DIR "${CMAKE_CURRENT_SOURCE_DIR}/resources/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging it would be great to push this scap-file with the others. @FedeDP probably you are the one with the right permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
+ Coverage 74.08% 74.20% +0.12%
==========================================
Files 253 253
Lines 30766 30832 +66
Branches 5386 5395 +9
==========================================
+ Hits 22792 22880 +88
+ Misses 7946 7925 -21
+ Partials 28 27 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
2f6e16f
to
6d327b3
Compare
Perf diff from master - unit tests
Perf diff from master - scap file
Heap diff from master - unit tests
Heap diff from master - scap file
|
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
4e74bed
to
1ba779a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 5d1a376831c13ca85201ee36ea90da9c9f2cca2a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR moves some scap files under the scap file test suite
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: