Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): only account for mean values in google benchmarks perf CI checks #2030

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Aug 28, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

…ecks.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 28, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Aug 28, 2024
@poiana poiana added the size/XS label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Perf diff from master - unit tests

     6.54%     -0.94%  [.] next
     1.59%     +0.83%  [.] sinsp::fetch_next_event
     3.05%     +0.65%  [.] gzfile_read
     4.46%     -0.59%  [.] sinsp_evt::load_params
     0.98%     -0.55%  [.] libsinsp::runc::match_container_id
     3.10%     -0.55%  [.] sinsp_thread_manager::get_thread_ref
     4.68%     -0.54%  [.] sinsp_parser::process_event
     0.93%     +0.50%  [.] sinsp_evt::get_direction
     7.24%     -0.47%  [.] sinsp::next
     9.09%     +0.47%  [.] sinsp_parser::reset

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0047         -0.0046           149           148           149           148
BM_sinsp_split_median                                          -0.0060         -0.0058           149           148           149           148
BM_sinsp_split_stddev                                          +0.4914         +0.5042             0             1             0             1
BM_sinsp_split_cv                                              +0.4984         +0.5111             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0263         -0.0262            42            41            42            41
BM_sinsp_concatenate_paths_relative_path_median                -0.0195         -0.0194            42            41            42            41
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8695         -0.8694             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8660         -0.8659             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0090         +0.0092            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   +0.0077         +0.0077            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.1163         +0.1188             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.1063         +0.1087             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1395         -0.1394            49            43            49            43
BM_sinsp_concatenate_paths_absolute_path_median                -0.1400         -0.1399            50            43            50            43
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3539         -0.3573             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.2492         -0.2532             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0117         -0.0115           354           350           354           350
BM_sinsp_split_container_image_median                          -0.0141         -0.0140           354           349           354           349
BM_sinsp_split_container_image_stddev                          +0.1076         +0.1090             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.1207         +0.1219             0             0             0             0

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (89edd36) to head (d2f25fd).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2030   +/-   ##
=======================================
  Coverage   74.20%   74.21%           
=======================================
  Files         253      253           
  Lines       30832    30832           
  Branches     5394     5396    +2     
=======================================
+ Hits        22880    22881    +1     
+ Misses       7934     7927    -7     
- Partials       18       24    +6     
Flag Coverage Δ
libsinsp 74.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…n perf ci.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana added size/S and removed size/XS labels Aug 28, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup: no need to test the build of benchmarks in normal CI now that they run in perf CI.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3004d3e into master Aug 28, 2024
46 checks passed
@poiana poiana deleted the fix/only_account_for_mean_values branch August 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants