-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schema): fix FUTEX_E flags parameter #2046
Conversation
The correct type is PT_FLAGS, not PT_ENUMFLAGS, as FUTEX_PRIVATE_FLAG and FUTEX_CLOCK_REALTIME are bitwise-or'ed with the other values. Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnosek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: a39018851a58dc2773e7f188a68217dc3a5693ad
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
==========================================
- Coverage 74.03% 74.02% -0.01%
==========================================
Files 254 254
Lines 31112 31112
Branches 5418 5436 +18
==========================================
- Hits 23033 23032 -1
- Misses 8052 8079 +27
+ Partials 27 1 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/milestone 0.18.0
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
This reverts commit a48653b. The fix is upstream: falcosecurity/libs#2046
The correct type is PT_FLAGS, not PT_ENUMFLAGS, as FUTEX_PRIVATE_FLAG and FUTEX_CLOCK_REALTIME are bitwise-or'ed with the other values.
The change is ABI-compatible and no driver changes are needed.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-patch
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: