Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): fix FUTEX_E flags parameter #2046

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

gnosek
Copy link
Contributor

@gnosek gnosek commented Sep 5, 2024

The correct type is PT_FLAGS, not PT_ENUMFLAGS, as FUTEX_PRIVATE_FLAG and FUTEX_CLOCK_REALTIME are bitwise-or'ed with the other values.

The change is ABI-compatible and no driver changes are needed.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

The correct type is PT_FLAGS, not PT_ENUMFLAGS, as FUTEX_PRIVATE_FLAG
and FUTEX_CLOCK_REALTIME are bitwise-or'ed with the other values.

Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
@poiana
Copy link
Contributor

poiana commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnosek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from hbrueckner and mstemm September 5, 2024 08:31
@poiana poiana added the approved label Sep 5, 2024
@poiana
Copy link
Contributor

poiana commented Sep 5, 2024

LGTM label has been added.

Git tree hash: a39018851a58dc2773e7f188a68217dc3a5693ad

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (9d2d151) to head (0fa656e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   74.03%   74.02%   -0.01%     
==========================================
  Files         254      254              
  Lines       31112    31112              
  Branches     5418     5436      +18     
==========================================
- Hits        23033    23032       -1     
- Misses       8052     8079      +27     
+ Partials       27        1      -26     
Flag Coverage Δ
libsinsp 74.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Sep 5, 2024
@poiana poiana merged commit eba3e31 into falcosecurity:master Sep 5, 2024
51 of 56 checks passed
@gnosek gnosek deleted the futex-schema-fix branch September 5, 2024 08:54
@FedeDP FedeDP modified the milestones: 0.18.0, 7.3.0+driver Sep 5, 2024
Copy link

github-actions bot commented Sep 6, 2024

Perf diff from master - unit tests

     4.79%     -0.90%  [.] sinsp_parser::process_event
     9.70%     +0.89%  [.] sinsp_parser::reset
     1.22%     -0.68%  [.] sinsp_evt::get_direction
     6.29%     -0.58%  [.] sinsp_evt::get_type
     1.06%     +0.47%  [.] sinsp_parser::parse_context_switch
     1.45%     -0.44%  [.] libsinsp::sinsp_suppress::process_event
     2.01%     +0.44%  [.] scap_event_decode_params
     3.55%     -0.43%  [.] sinsp_thread_manager::find_thread
     4.19%     -0.43%  [.] gzfile_read
     0.79%     +0.42%  [.] sinsp_filter_check::parse_field_name

Heap diff from master - unit tests

peak heap memory consumption: 7.22K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0042         -0.0041           145           145           145           145
BM_sinsp_split_median                                          -0.0045         -0.0044           145           145           145           145
BM_sinsp_split_stddev                                          -0.0724         -0.0724             1             1             1             1
BM_sinsp_split_cv                                              -0.0684         -0.0686             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0026         +0.0027            42            42            42            42
BM_sinsp_concatenate_paths_relative_path_median                +0.0024         +0.0025            42            42            42            42
BM_sinsp_concatenate_paths_relative_path_stddev                -0.3876         -0.3871             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.3891         -0.3887             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0154         -0.0153            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0147         -0.0145            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.1609         -0.1617             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.1478         -0.1487             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0455         +0.0456            43            45            43            45
BM_sinsp_concatenate_paths_absolute_path_median                +0.0468         +0.0469            43            45            43            45
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.1698         +0.1701             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.1188         +0.1190             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0196         -0.0195           349           342           349           342
BM_sinsp_split_container_image_median                          -0.0213         -0.0212           350           342           349           342
BM_sinsp_split_container_image_stddev                          -0.4664         -0.4656             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.4557         -0.4549             0             0             0             0

gnosek added a commit to falcosecurity/plugin-sdk-rs that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants