Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test/drivers): fixed s390x Werror related failures for drivers tests #2066

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 13, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Extracted from #2064 .

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

…tests.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 13, 2024

/milestone 0.18.0

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (16ac62f) to head (0738711).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2066      +/-   ##
==========================================
+ Coverage   73.55%   73.58%   +0.02%     
==========================================
  Files         253      253              
  Lines       31863    31867       +4     
  Branches     5639     5652      +13     
==========================================
+ Hits        23437    23449      +12     
- Misses       8410     8417       +7     
+ Partials       16        1      -15     
Flag Coverage Δ
libsinsp 73.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit 448570d into master Sep 13, 2024
47 checks passed
@poiana poiana deleted the fix/s390x_drivers_test branch September 13, 2024 14:24
Copy link

Perf diff from master - unit tests

     3.11%     -1.33%  [.] scap_event_decode_params
     6.23%     +1.20%  [.] sinsp::next
     3.44%     +0.98%  [.] sinsp_thread_manager::find_thread
     4.26%     -0.96%  [.] gzfile_read
    10.54%     +0.77%  [.] sinsp_parser::reset
     4.71%     -0.72%  [.] sinsp_evt::load_params
     3.83%     +0.60%  [.] sinsp_parser::process_event
     1.48%     +0.58%  [.] libsinsp::sinsp_suppress::process_event
     6.28%     -0.58%  [.] sinsp_evt::get_type
     0.88%     +0.52%  [.] sinsp_evt::get_ts

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0190         +0.0190           148           151           148           151
BM_sinsp_split_median                                          +0.0213         +0.0213           148           151           148           151
BM_sinsp_split_stddev                                          +2.3228         +2.3219             0             1             0             1
BM_sinsp_split_cv                                              +2.2608         +2.2600             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1072         +0.1072            41            46            41            46
BM_sinsp_concatenate_paths_relative_path_median                +0.1073         +0.1073            41            46            41            46
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1109         +0.1147             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0033         +0.0067             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0049         -0.0049            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0002         -0.0002            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7751         -0.7750             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7740         -0.7739             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1876         +0.1876            41            49            41            49
BM_sinsp_concatenate_paths_absolute_path_median                +0.1830         +0.1829            41            49            41            49
BM_sinsp_concatenate_paths_absolute_path_stddev                +3.9877         +3.9909             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +3.1998         +3.2026             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0113         -0.0113           359           355           359           355
BM_sinsp_split_container_image_median                          -0.0131         -0.0131           359           354           359           354
BM_sinsp_split_container_image_stddev                          +0.8994         +0.8980             2             4             2             4
BM_sinsp_split_container_image_cv                              +0.9211         +0.9197             0             0             0             0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants