fix(ci): fix build-scap-open-w-extern-bpf-skeleton job

[FedeDP]

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Since we do not rely upon centos7 anymore, drop it.
Moreover, bump actions/download-artifact to latest release to be able to communicate correctly with actions/upload-artifact.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[github-actions]

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

[github-actions]

Perf diff from master - unit tests

    11.08%     -1.64%  [.] sinsp_parser::reset
     0.63%     +0.87%  [.] sinsp_filter_check::parse_field_name
     4.52%     +0.82%  [.] sinsp_parser::process_event
     0.83%     -0.70%  [.] std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, true> > >::_M_deallocate_nodes
     3.92%     +0.69%  [.] sinsp_evt::load_params
     4.23%     +0.66%  [.] next
     1.89%     +0.49%  [.] sinsp::fetch_next_event
     6.18%     +0.48%  [.] sinsp::next
     0.34%     +0.47%  [.] sinsp_parser::parse_clone_exit_child
     1.61%     +0.47%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release

Heap diff from master - unit tests

peak heap memory consumption: -7.23K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0163         -0.0163           153           150           153           150
BM_sinsp_split_median                                          -0.0188         -0.0188           153           150           153           150
BM_sinsp_split_stddev                                          -0.5183         -0.5178             1             1             1             1
BM_sinsp_split_cv                                              -0.5103         -0.5098             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0697         -0.0697            63            59            63            59
BM_sinsp_concatenate_paths_relative_path_median                -0.0725         -0.0725            63            59            63            59
BM_sinsp_concatenate_paths_relative_path_stddev                -0.1062         -0.1063             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0392         -0.0394             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0361         -0.0361            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0347         -0.0347            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.2401         -0.2386             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.2117         -0.2101             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0016         -0.0016            61            61            61            61
BM_sinsp_concatenate_paths_absolute_path_median                +0.0092         +0.0092            61            61            61            61
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.8605         -0.8605             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.8603         -0.8603             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0338         -0.0338           396           382           396           382
BM_sinsp_split_container_image_median                          -0.0353         -0.0352           396           382           396           382
BM_sinsp_split_container_image_stddev                          -0.3100         -0.3096             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.2859         -0.2854             0             0             0             0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (6d2bec3) to head (f3d8f8d).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2109      +/-   ##
==========================================
- Coverage   73.69%   73.69%   -0.01%     
==========================================
  Files         253      253              
  Lines       31914    31914              
  Branches     5617     5610       -7     
==========================================
- Hits        23520    23519       -1     
- Misses       8365     8379      +14     
+ Partials       29       16      -13     

Flag	Coverage Δ
libsinsp	73.69% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FedeDP]

/milestone 0.19.0

[Andreagit97]

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[FedeDP]

/unhold