-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(libsinsp): invalid field_info check #2135
fix(libsinsp): invalid field_info check #2135
Conversation
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2135 +/- ##
=======================================
Coverage 74.46% 74.46%
=======================================
Files 254 254
Lines 33333 33333
Branches 5708 5731 +23
=======================================
Hits 24820 24820
- Misses 8487 8506 +19
+ Partials 26 7 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM label has been added. Git tree hash: 9a5784abbb757586bab29a3b0dc2e0d9d2450392
|
/milestone 0.19.0 |
Can you rebase on latest master to unlock arm64 CI? :) We switched runners from actuated to the cncf provided ones. |
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
5419ba1
to
9a5f273
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 73ca4be8947c7afe5f912aafbd984eb56051fe66
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: