Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libsinsp): invalid field_info check #2135

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mrgian
Copy link
Contributor

@mrgian mrgian commented Oct 28, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Oct 28, 2024

Perf diff from master - unit tests

     8.14%     -1.67%  [.] sinsp::next
     4.65%     +0.87%  [.] sinsp_evt::get_type
     2.61%     +0.65%  [.] sinsp_thread_manager::get_thread_ref
     5.74%     -0.64%  [.] next
     1.03%     -0.61%  [.] sinsp_evt::get_direction
     4.08%     -0.61%  [.] sinsp_evt::load_params
     1.78%     -0.53%  [.] libsinsp::sinsp_suppress::process_event
     1.31%     -0.53%  [.] sinsp_parser::parse_context_switch
     1.16%     +0.51%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.57%     +0.50%  [.] scap_event_has_large_payload

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0163         +0.0162           151           153           151           153
BM_sinsp_split_median                                          +0.0082         +0.0081           153           154           153           154
BM_sinsp_split_stddev                                          -0.6710         -0.6710             5             2             5             2
BM_sinsp_split_cv                                              -0.6763         -0.6763             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0119         +0.0119            56            56            56            56
BM_sinsp_concatenate_paths_relative_path_median                +0.0112         +0.0112            56            56            56            56
BM_sinsp_concatenate_paths_relative_path_stddev                +0.5338         +0.5332             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.5158         +0.5152             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0461         -0.0461            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0450         -0.0450            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8225         -0.8212             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8140         -0.8125             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0042         -0.0043            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.0025         -0.0026            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3559         -0.3562             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3532         -0.3534             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0054         +0.0053           391           393           391           393
BM_sinsp_split_container_image_median                          +0.0055         +0.0054           391           393           391           393
BM_sinsp_split_container_image_stddev                          -0.5253         -0.5253             3             1             3             1
BM_sinsp_split_container_image_cv                              -0.5279         -0.5278             0             0             0             0

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (b4ca436) to head (9a5f273).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2135   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         254      254           
  Lines       33333    33333           
  Branches     5708     5731   +23     
=======================================
  Hits        24820    24820           
- Misses       8487     8506   +19     
+ Partials       26        7   -19     
Flag Coverage Δ
libsinsp 74.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana
Copy link
Contributor

poiana commented Oct 29, 2024

LGTM label has been added.

Git tree hash: 9a5784abbb757586bab29a3b0dc2e0d9d2450392

@FedeDP
Copy link
Contributor

FedeDP commented Oct 29, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 29, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Oct 29, 2024

Can you rebase on latest master to unlock arm64 CI? :) We switched runners from actuated to the cncf provided ones.

Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
@mrgian mrgian force-pushed the fix-valid-field-info-check branch from 5419ba1 to 9a5f273 Compare October 29, 2024 16:18
@poiana poiana removed the lgtm label Oct 29, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 29, 2024

LGTM label has been added.

Git tree hash: 73ca4be8947c7afe5f912aafbd984eb56051fe66

@poiana
Copy link
Contributor

poiana commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0ec8bac into falcosecurity:master Oct 29, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants