Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable a flaky test #2154

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This test is required and blocks the CI on almost all the PRs, moreover, we always have a red X on all PRs so since this has been broken for a while without a fix I would suggest disabling it until we can figure out the real cause behind the issue.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97 Andreagit97 added this to the 0.19.0 milestone Nov 11, 2024
@Andreagit97 Andreagit97 changed the title ci: disable a flacky test ci: disable a flaky test Nov 11, 2024
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@Andreagit97
Copy link
Member Author

Disabled on arm64

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 11, 2024

LGTM label has been added.

Git tree hash: 7ca47ec72ebef8a3a6981c0bc4bac7d915009229

Copy link

Perf diff from master - unit tests

     4.52%     +0.89%  [.] sinsp_evt::get_type
     9.77%     -0.87%  [.] sinsp_parser::reset
     2.32%     -0.81%  [.] scap_event_decode_params
     1.74%     -0.70%  [.] libsinsp::sinsp_suppress::process_event
     1.38%     -0.61%  [.] sinsp_threadinfo::~sinsp_threadinfo
     3.96%     -0.60%  [.] sinsp_evt::load_params
     1.68%     +0.59%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     2.57%     +0.47%  [.] sinsp_thread_manager::get_thread_ref
     1.02%     +0.44%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     3.45%     -0.41%  [.] gzfile_read

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0157         -0.0157           145           143           145           143
BM_sinsp_split_median                                          -0.0139         -0.0139           145           143           145           143
BM_sinsp_split_stddev                                          -0.3061         -0.3055             1             0             1             0
BM_sinsp_split_cv                                              -0.2951         -0.2945             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0209         -0.0209            57            56            57            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0319         -0.0319            58            56            58            56
BM_sinsp_concatenate_paths_relative_path_stddev                -0.2915         -0.2928             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.2764         -0.2777             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0468         -0.0468            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0441         -0.0441            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8440         -0.8442             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8363         -0.8365             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0852         -0.0851            61            56            61            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.0815         -0.0815            61            56            61            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7911         -0.7911             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7716         -0.7716             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0197         +0.0198           385           393           385           393
BM_sinsp_split_container_image_median                          +0.0174         +0.0174           384           391           384           391
BM_sinsp_split_container_image_stddev                          +0.7669         +0.7666             3             5             3             5
BM_sinsp_split_container_image_cv                              +0.7327         +0.7324             0             0             0             0

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (0e177db) to head (99bdd16).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2154   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files         254      254           
  Lines       33505    33505           
  Branches     5730     5747   +17     
=======================================
  Hits        25054    25054           
- Misses       8444     8451    +7     
+ Partials        7        0    -7     
Flag Coverage Δ
libsinsp 74.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit facfcc3 into falcosecurity:master Nov 12, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants