Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix shared-libs and emscripten CI #2203

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Andreagit97
Copy link
Member

@Andreagit97 Andreagit97 commented Dec 16, 2024

What type of PR is this?

/kind failing-test

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@poiana poiana requested review from FedeDP and hbrueckner December 16, 2024 09:46
@Andreagit97 Andreagit97 changed the title chore: use ubuntu-22.04 chore(ci): use ubuntu-22.04 in shared libs Dec 16, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Dec 16, 2024

During the weekend, runner images ubuntu-24.04 got updates and a couple of jobs are now failing.
Thanks @Andreagit97 , let's see if enforcing 22.04 will fix the issues.

@Andreagit97 Andreagit97 changed the title chore(ci): use ubuntu-22.04 in shared libs chore(ci): fix shared-libs and emscripten CI Dec 16, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Dec 16, 2024

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Dec 16, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 16, 2024

LGTM label has been added.

Git tree hash: 6099b2bb1f72523b330d2aa8959b5d287837364b

Copy link

Perf diff from master - unit tests

     9.30%     +0.90%  [.] sinsp::next
     1.63%     +0.90%  [.] sinsp_evt_filter::sinsp_evt_filter
    10.71%     -0.83%  [.] sinsp_parser::reset
     7.58%     -0.57%  [.] sinsp_evt::get_type
     1.83%     +0.49%  [.] next
     5.82%     -0.43%  [.] next_event_from_file
     2.36%     -0.42%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.52%     -0.28%  [.] sinsp_parser::parse_rw_exit
     0.93%     +0.25%  [.] sinsp_evt::get_syscall_return_value
     0.45%     -0.25%  [.] convert_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0161         +0.0159           146           148           146           148
BM_sinsp_split_median                                          +0.0170         +0.0167           146           148           146           148
BM_sinsp_split_stddev                                          +0.7862         +0.7832             0             1             0             1
BM_sinsp_split_cv                                              +0.7579         +0.7554             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0202         +0.0200            61            62            61            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0230         +0.0227            61            62            61            62
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7552         -0.7552             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.7601         -0.7601             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0341         -0.0343            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0324         -0.0327            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.6454         +0.6472             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.7036         +0.7057             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0486         +0.0484            61            64            61            64
BM_sinsp_concatenate_paths_absolute_path_median                +0.0487         +0.0486            61            64            61            64
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3428         -0.3413             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3733         -0.3717             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0011         +0.0009           392           393           392           393
BM_sinsp_split_container_image_median                          -0.0010         -0.0013           393           393           393           393
BM_sinsp_split_container_image_stddev                          -0.3453         -0.3385             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3460         -0.3391             0             0             0             0

@poiana
Copy link
Contributor

poiana commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (3126a97) to head (4e46399).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2203   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files         261      261           
  Lines       33878    33878           
  Branches     5801     5801           
=======================================
  Hits        25475    25475           
  Misses       8403     8403           
Flag Coverage Δ
libsinsp 75.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit 0bdee92 into falcosecurity:master Dec 16, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants