Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added a job in ci which builds the all examples #83

Merged

Conversation

GLVSKiriti
Copy link
Contributor

@GLVSKiriti GLVSKiriti commented Apr 12, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #77

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@poiana
Copy link

poiana commented Apr 12, 2024

Welcome @GLVSKiriti! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

@poiana poiana added the size/S label Apr 12, 2024
@GLVSKiriti
Copy link
Contributor Author

@jasondellaluce @leogr As mentioned in the issue I implemented the first task

Can you please give me guidance on how to implement the second task

Run the example plugins with a given Falco version (maybe the last released one + dev?) so that we can catch trivial bugs in the SDK

@leogr
Copy link
Member

leogr commented Apr 16, 2024

/assign @leogr
/assign @jasondellaluce

@poiana
Copy link

poiana commented Jul 15, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Jul 18, 2024

/remove-lifecycle stale

@poiana poiana added the lgtm label Jul 18, 2024
@poiana
Copy link

poiana commented Jul 18, 2024

LGTM label has been added.

Git tree hash: 1e6a4ab74eaf8ca6f1a075425b9479cb5594ffff

@poiana
Copy link

poiana commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ede3348 into falcosecurity:main Jul 18, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the BuildExamplesInCiWithMinGoVersion branch July 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants