Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(AsyncEventPlugin): helper to create async events #32

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

deepskyblue86
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugin

/area plugin_tests

What this PR does / why we need it:
Reduce the boilerplate to create async events by introducing AsyncEventPlugin::async_event

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Introduce AsyncEventPlugin::async_event helper to generate async events

Reduce the boilerplate to create async events by introducing
AsyncEventPlugin::async_event

Signed-off-by: Angelo Puglisi <angelo.puglisi@sysdig.com>
@poiana
Copy link

poiana commented Dec 12, 2024

Welcome @deepskyblue86! It looks like this is your first PR to falcosecurity/plugin-sdk-rs 🎉

@poiana poiana requested review from Andreagit97 and gnosek December 12, 2024 18:50
@poiana poiana added the size/M label Dec 12, 2024
@poiana
Copy link

poiana commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, gnosek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Dec 13, 2024

LGTM label has been added.

Git tree hash: abcb7c71f5ebb6505eb679698efca0551d656b23

@poiana poiana merged commit 0e94782 into falcosecurity:main Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants