-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: Adding @darryk10 to rules approvers #247
Conversation
Big +1 from me! /hold until we reach the majority or a week has passed cc @falcosecurity/rules-maintainers |
+1 , thank you @darryk10 ! |
PS this PR triggered a bug in the CI that validates rules. I will dig into it. It's unrelated to this PR, so please ignore it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well deserved!
LGTM label has been added. Git tree hash: 12a4ec6a0bd814c4114af74d1b626007e119303b
|
Big +1 from me! |
Big +1 great pleasure to welcome you as approver ❤️ |
+1 from me! Welcome!! |
Added myself to maintainers for rules Signed-off-by: Stefano Chierici <stefano.chierici@sysdig.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 5 binding votes in favor and nobody against Majory vote has passed!
@darryk10 welcome onboard! 👏
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darryk10, Kaizhe, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: b30d8cb409ada1fc977f8bf0ca95768acc9c3a31
|
What type of PR is this?
After more than a year as a reviewer in the falcosecurity/rules repo and more than 3 years as a contributor in the Falco community, I want to propose myself as a rule approver.
Any specific area of the project related to this PR?
Proposed rule maturity level
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: