Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: Adding @darryk10 to rules approvers #247

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

darryk10
Copy link
Contributor

What type of PR is this?
After more than a year as a reviewer in the falcosecurity/rules repo and more than 3 years as a contributor in the Falco community, I want to propose myself as a rule approver.

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@leogr
Copy link
Member

leogr commented May 20, 2024

Big +1 from me!

/hold until we reach the majority or a week has passed

cc @falcosecurity/rules-maintainers

@LucaGuerra
Copy link
Contributor

+1 , thank you @darryk10 !

@LucaGuerra LucaGuerra changed the title vote: Adding @darry10 to rules approvers vote: Adding @darryk10 to rules approvers May 20, 2024
@leogr
Copy link
Member

leogr commented May 20, 2024

PS this PR triggered a bug in the CI that validates rules. I will dig into it. It's unrelated to this PR, so please ignore it.

Copy link
Contributor

@Kaizhe Kaizhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well deserved!

@poiana
Copy link

poiana commented May 20, 2024

LGTM label has been added.

Git tree hash: 12a4ec6a0bd814c4114af74d1b626007e119303b

@Andreagit97
Copy link
Member

Big +1 from me!

@incertum
Copy link
Contributor

incertum commented May 20, 2024

Big +1 great pleasure to welcome you as approver ❤️

@FedeDP
Copy link
Contributor

FedeDP commented May 20, 2024

+1 from me! Welcome!!

Added myself to maintainers for rules

Signed-off-by: Stefano Chierici <stefano.chierici@sysdig.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With 5 binding votes in favor and nobody against Majory vote has passed!

@darryk10 welcome onboard! 👏

/hold cancel

@poiana
Copy link

poiana commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, Kaizhe, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented May 29, 2024

LGTM label has been added.

Git tree hash: b30d8cb409ada1fc977f8bf0ca95768acc9c3a31

@poiana poiana merged commit 679a50a into falcosecurity:main May 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants