Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(config/jobs/build-libs): add build job for WITH_CHISEL option #341

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 22, 2021

@poiana
Copy link
Contributor

poiana commented Mar 24, 2021

@leogr: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
build-images-update-falco-k8s-manifests 0924848 link /test build-images-update-falco-k8s-manifests

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the update/libs-job-with-chisel branch from 0924848 to d51bd08 Compare March 24, 2021 15:30
@jonahjon
Copy link
Contributor

The job looks good, the PR might need to be updated or refreshed, not sure if Prow can retroactively add to an open PR though if that was the goal.

@leogr
Copy link
Member Author

leogr commented Mar 26, 2021

The job looks good, the PR might need to be updated or refreshed, not sure if Prow can retroactively add to an open PR though if that was the goal.

No need to retroactively add to an open PR, because those PRs that will touch the chisel functionality will need a rebase anyways. So we will manually handle it eventually.

@jonahjon jonahjon self-requested a review March 26, 2021 16:08
Copy link
Contributor

@jonahjon jonahjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see you got a hold on still too.

@poiana
Copy link
Contributor

poiana commented Mar 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Mar 26, 2021

LGTM label has been added.

Git tree hash: 44d1e5a75acab802d1b2d214f0180aa27d30dab3

@leogr
Copy link
Member Author

leogr commented Mar 29, 2021

/hold cancel
Since falcosecurity/libs#14 has been merged

@leodido
Copy link
Member

leodido commented Mar 29, 2021

/hold cancel

@poiana poiana merged commit 90a1818 into master Mar 29, 2021
@poiana poiana deleted the update/libs-job-with-chisel branch March 29, 2021 09:43
@poiana
Copy link
Contributor

poiana commented Mar 29, 2021

@leogr: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key build-libs.yaml using file config/jobs/build-libs/build-libs.yaml

In response to this:

/hold
See falcosecurity/libs#14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants