-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(config/jobs/build-libs): add build job for WITH_CHISEL option #341
Conversation
@leogr: The following test failed, say
Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
0924848
to
d51bd08
Compare
The job looks good, the PR might need to be updated or refreshed, not sure if Prow can retroactively add to an open PR though if that was the goal. |
No need to retroactively add to an open PR, because those PRs that will touch the chisel functionality will need a rebase anyways. So we will manually handle it eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, see you got a hold on still too.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 44d1e5a75acab802d1b2d214f0180aa27d30dab3
|
/hold cancel |
/hold cancel |
@leogr: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold
See falcosecurity/libs#14