Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(images/autobump): make bump of component and config optional #999

Closed
wants to merge 1 commit into from

Conversation

maxgio92
Copy link
Member

This PR allows to autobump components and Prow config separately.

For example it could be bumped a Peribolos job only, without the requirement of having Prow config in place.

Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
@poiana
Copy link
Contributor

poiana commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented May 16, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented May 18, 2023

/remove-lifecycle stale

Hey @maxgio92

Sorry, I lost track of this. I guess it needs at least a rebase to update the CI checks. I'd suggest taking a look at this immediately after the Falco release. wdyt?

cc @FedeDP

@maxgio92
Copy link
Member Author

Hi @leogr, no worries. I think we should close this in favor of the new autobumper.

@cappellinsamuele working on that already :) And #1132 will definitely superseed this.

WDYT?

@leogr
Copy link
Member

leogr commented May 19, 2023

Hi @leogr, no worries. I think we should close this in favor of the new autobumper.

@cappellinsamuele working on that already :) And #1132 will definitely superseed this.

WDYT?

Ok, for me!

I just wanted to sort this out 😺

@FedeDP
Copy link
Contributor

FedeDP commented Jul 5, 2023

Given that autobump script is no more existent, is this still needed?
@maxgio92

@maxgio92
Copy link
Member Author

maxgio92 commented Jul 5, 2023

You're right, totally agree @FedeDP, thank you.

/close

@poiana poiana closed this Jul 5, 2023
@poiana
Copy link
Contributor

poiana commented Jul 5, 2023

@maxgio92: Closed this PR.

In response to this:

You're right, totally agree @FedeDP, thank you.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants