Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use float texture in GamepadLoader #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use float texture in GamepadLoader #24

wants to merge 2 commits into from

Conversation

fand
Copy link
Owner

@fand fand commented Jul 6, 2018

#21

KoltesDigital
KoltesDigital reviewed Jul 17, 2018
View reviewed changes
src/gamepad-loader.ts Outdated
});
gamepad.axes.forEach((axis: any, i: number) => {
this.array[i + 128] = axis * 128 + 128;
this.array[i + 128] = Math.max(-1, Math.min(1, axis));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't clamp the value. Specs state axis values are already in range (-1, 1). And if ever I hack a gamepad to yield values outside the range, I'd be happy that VEDA lets me do so.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, okay I'll pass raw values to the texture 🕹

@KoltesDigital KoltesDigital mentioned this pull request Jul 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoltesDigital KoltesDigital KoltesDigital left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fand @KoltesDigital