Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimb does not enter input mode for contenteditable='true' attribute #237

Closed
j1r1k opened this issue Aug 22, 2015 · 3 comments
Closed

Vimb does not enter input mode for contenteditable='true' attribute #237

j1r1k opened this issue Aug 22, 2015 · 3 comments
Labels

Comments

@j1r1k
Copy link
Contributor

j1r1k commented Aug 22, 2015

Steps to reproduce:

  1. Navigate to keep.google.com (must be logged in google account tho).
  2. Click into "Add note" field

Vimb should enter input mode at this point, but it does not. Input field is div with contenteditable='true'.

I suppose that this is not limited to keep.google.com, but I did not find any other app using this tag/attribute combo.

Might be somehow related to #114. But I did not fully understand the fix made there.

@j1r1k
Copy link
Contributor Author

j1r1k commented Aug 22, 2015

I have came up with a quick fix and I am not sure whether this is a nice solution - therefore I am humbly asking for a review/comments.

Secondly this fix does work only with a mouse click. It does not work with a follow hint.

@fanglingsu
Copy link
Owner

The fix looks right, great work. I've merged it into the master branch. But we should keep the issue open to fix the other things related tpo editable elements.

  1. Allow to focus contenteditable elements by hinting ;o and possibly also ;y and to switch vimb into input mode too.
  2. Allow to use these elements with the editor command by hinting ;e or if the focus is already on by CTRL-T.

@fanglingsu
Copy link
Owner

Moved the open enhancements into #248 so we can close this issue.

0-wiz-0 pushed a commit to NetBSD/pkgsrc-wip that referenced this issue Dec 18, 2015
Changes:
The new vimb 2.11 is now released. With some new features and important bug
fixes.

I thank following people for providing ideas and patches:

- Benjamin Petrenko
- Chris Salzberg
- Dmitrij D. Czarkoff
- Jiri Marsicek
- Leonardo Taccari
- PLR
- Yutao Yuan

Added

* Added hint-number-same-length option
* VERBOSE flag to Makefile to toggle verbose make on
* `<Esc>` removes selections in normal mode
* Support for multiple configuration profiles. New parameter `-p` or
  `--profile`
* Adds support for contenteditable attribute as input mode trigger
  [#237](fanglingsu/vimb#237)
* Added `^` as normal mode alias of `0`
  [#236](fanglingsu/vimb#236)
* Added :source command to source a config file
* Added path completion for :save command too
* Added closed-max-items option to allow to store more than one closed page

Changed

* Set only required CFLAGS
* Replaced `-Wpedantic` with `-pedantic` CFLAGS for older gcc versions
* Check for focused editable element as soon as possible
* Do not blur the focused element after alt-tabbing
* Show typed text as last completion entry to easily change it
  [#253](fanglingsu/vimb#253)

Fixed

* Fixed [#224](fanglingsu/vimb#224): Wrong URL and
  titles shown in case one or more pages could not be loaded.
* Fixed Makefile install target using -D
* Fixed [#232](fanglingsu/vimb#232): Fixed misplaced
  hint labels on some sites
* Fixed [#235](fanglingsu/vimb#235): Randomly reset
  cookie file
* Fixed none POSIX `echo -n` call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants