Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache/data files in $XDG_CONFIG_HOME #582

Closed
thunktone opened this issue Dec 3, 2019 · 9 comments
Closed

Cache/data files in $XDG_CONFIG_HOME #582

thunktone opened this issue Dec 3, 2019 · 9 comments
Assignees
Labels
pinned stale bot protection

Comments

@thunktone
Copy link

I just found my browsing history, cookies etc in ~/.config/vimb. They really belong in $XDG_CACHE_HOME or possibly $XDG_DATA_HOME. Fortunately I spotted this before commiting the files to my config git repository. Please change this before someone accidentaly publishes their browsing history on github or something. See freedesktop basedir spec.

@fanglingsu
Copy link
Owner

@thunktone You are right. $XDG_CONFIG_HOME is the wrong place used since the early days of vimb. I'll try to move all files except of config, style.css, scripts.js and bookmark to $XDG_DATA_HOME/vimb/[PROFILE/].

@fanglingsu fanglingsu self-assigned this Dec 4, 2019
@herrsimon
Copy link

A related suggestion: I think it would be very useful to add options for specifying the paths and filenames for all files individually, either just via the command line when calling vimb (analogously to '--config') or optimally as settings, so that the files can be changed dynamically. This would in particular be very nice for the style.css and script.js files, which could then be changed via auto-commands, depending on the URI.

@stale
Copy link

stale bot commented Mar 5, 2020

This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 5, 2020
@stale
Copy link

stale bot commented Mar 12, 2020

This issue has been automatically closed because it has not had activity since it was marked as stale. Thank you for your contributions.

@stale stale bot closed this as completed Mar 12, 2020
@iamleot
Copy link
Contributor

iamleot commented Mar 13, 2020

I think that issue should be reopened (it is not really stale, just not worked on).

@fanglingsu
Copy link
Owner

I'm not sure which files belong to config, data or to cache directory. I see the files as configuration that I inspect and edit with editor - except of the cookies.db.

@iamleot
Copy link
Contributor

iamleot commented Mar 18, 2020

IMHO:

  • config, script.js and style.css should be under XDG_CONFIG_HOME
  • all other files (cookies.db, closed, history, bookmark, command, queue and search) under XDG_DATA_HOME

@fanglingsu fanglingsu reopened this Mar 30, 2020
@stale stale bot removed the stale label Mar 30, 2020
@fanglingsu fanglingsu added the pinned stale bot protection label Mar 30, 2020
fanglingsu added a commit that referenced this issue Oct 12, 2020
Do not store all files in XDG_CONFIG_HOME.
fanglingsu added a commit that referenced this issue Oct 12, 2020
Do not store all files in XDG_CONFIG_HOME.
@fanglingsu
Copy link
Owner

Like @iamleot suggested the config, script.js and style.css are kept in $XDG_CONFIG_HOME all other files are now in $XDG_DATA_HOME. Files are not moved automaticallyand should therefor moved from config to data home e.g. by

mv $XDG_CONFIG_HOME/vimb/{bookmark,closed,command,cookies.db,history,queue,search} $XDG_DATA_HOME/vimb

@iamleot
Copy link
Contributor

iamleot commented Oct 19, 2020

Thank you @fanglingsu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned stale bot protection
Projects
None yet
Development

No branches or pull requests

4 participants