Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md for CGAL #60

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Update README.md for CGAL #60

merged 1 commit into from
Sep 22, 2021

Conversation

lrineau
Copy link
Contributor

@lrineau lrineau commented Sep 21, 2021

  • CGAL is no longer under QPL since version 4.0 (2012).
  • Update the URLs to the documentation of CGAL.

@lrineau
Update README.md for CGAL
29a1828 
- CGAL is no longer under QPL since version 4.0 (2012).
- Update the URLs to the documentation of CGAL.
@lrineau
Copy link
Contributor Author

lrineau commented Sep 21, 2021

@fangq I have not updated README.txt. It seems to be generated from README.md with a tool.

fangq
fangq approved these changes Sep 22, 2021
View reviewed changes
Copy link
Owner

@fangq fangq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will accept this update, assuming in the future the cgal executables will all be replaced by those compiled with the newer licenses.

@fangq fangq merged commit a7673f5 into fangq:master Sep 22, 2021
@lrineau lrineau deleted the modify_README branch September 22, 2021 12:12
@lrineau
Copy link
Contributor Author

lrineau commented Sep 22, 2021

I did not realized there was that need to recompile the cgal* tools from bin/. How do you generate, and test them? Could the Github Actions CI generate and test them automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangq fangq fangq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrineau @fangq