sanctuary-type-classes@8.1.1 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Mar 3, 2018
| @@ -17,7 +17,7 @@ | |||
| "dependencies": { | |||
| "fantasy-land": "3.5.x", | |||
| "jsverify": "0.8.x", | |||
| "sanctuary-type-classes": "8.1.x" | |||
| "sanctuary-type-classes": "8.1.1" | |||
There was a problem hiding this comment.
I considered "~8.1.1" here, but these projects are so tightly coupled that specifying an exact version seems prudent.
davidchambers
force-pushed
the
davidchambers/sanctuary
branch
from
d89bca0 to
6ad8599
Compare
Avaq
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v8.1.1 release is crucial for this project as it fixes the handling of
NaNinZ.lte. Without this fix a project testing the lawfulness ofArbitrary (Identity Number)would run into problems ifIdentity (NaN)is produced by the arbitrary. See sanctuary-js/sanctuary-type-classes#88 for details./cc @Avaq, @CrossEye