Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix network conversions #156

Closed
zkao opened this issue Oct 28, 2021 · 1 comment · Fixed by #166
Closed

fix network conversions #156

zkao opened this issue Oct 28, 2021 · 1 comment · Fixed by #166

Comments

@zkao
Copy link
Member

zkao commented Oct 28, 2021

e.g.

impl From<farcaster_core::blockchain::Network> for monero::Network {
    fn from(network: farcaster_core::blockchain::Network) -> Self {
        match network {
            blockchain::Network::Mainnet => monero::Network::Mainnet,
            blockchain::Network::Testnet => monero::Network::Stagenet,
            blockchain::Network::Local => monero::Network::Mainnet,
        }
    }
}
@zkao zkao closed this as completed Oct 28, 2021
@zkao zkao reopened this Oct 28, 2021
@zkao zkao changed the title add network conversions fix network conversions Oct 28, 2021
@zkao
Copy link
Member Author

zkao commented Oct 28, 2021

blockchain::Network::Local should map to monero::Network::Mainnet

h4sh3d added a commit to h4sh3d/farcaster-core that referenced this issue Nov 1, 2021
@h4sh3d h4sh3d linked a pull request Nov 1, 2021 that will close this issue
h4sh3d added a commit to h4sh3d/farcaster-core that referenced this issue Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant