Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage accordant address #142

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

h4sh3d
Copy link
Member

@h4sh3d h4sh3d commented Sep 24, 2021

Based on #139

Add code to generate accordant address by hand in a test and add support in core to do the same with data coming from the protocol.

@h4sh3d h4sh3d force-pushed the manage-accordant-address branch from e6edbe5 to d537434 Compare September 27, 2021 06:51
Add a new method on trait Accordant to generate the accordant address
used to lock funds based on keys generated during the commit/reveal
phase.
@h4sh3d h4sh3d marked this pull request as ready for review September 27, 2021 06:57
Copy link
Member

@Lederstrumpf Lederstrumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. I expanded the test to also check derive_lock_address's result - the unit test already reproduces its logic, but otherwise the evolving library does not get tested for correctness - only the unit test's (probably static) logic does ;)

@Lederstrumpf Lederstrumpf merged commit 75dbcab into farcaster-project:main Sep 27, 2021
@h4sh3d h4sh3d deleted the manage-accordant-address branch October 29, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants