Public offer strict encoding #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lederstrumpf
force-pushed
the
public_offer_id_strict_encoding
branch
from
e045876 to
465282c
Compare
Lederstrumpf
changed the title
|
I'm not convinced the best way for public offer serde is with the string, if we want a string we use a String type and have it with |
cargo fmt
Lederstrumpf
force-pushed
the
public_offer_id_strict_encoding
branch
from
465282c to
cc56dfb
Compare
|
Fully agree it's not the best way. I suggest we use this and switch to your proper serde impl once that's done, unless you can finish that quickly? |
|
Fair enough, let's add this and release 0.4.3, then add proper support in 0.5. |
Lederstrumpf
force-pushed
the
public_offer_id_strict_encoding
branch
from
aa3d3ff to
cb5eae0
Compare
h4sh3d
reviewed
Dec 6, 2021
src/negotiation.rs
Outdated
| let encoded = base58_monero::encode_check(consensus::serialize(self).as_ref()) | ||
| .expect("Encoding in base58 check works"); | ||
| s.push_str(&encoded); | ||
| serializer.serialize_str(s.as_ref()) |
There was a problem hiding this comment.
This code will also run if we use to_string, we should use it to maintain only one interface IMO
Lederstrumpf
force-pushed
the
public_offer_id_strict_encoding
branch
from
d5d7d05 to
f1072a4
Compare
Lederstrumpf
force-pushed
the
public_offer_id_strict_encoding
branch
from
f1072a4 to
a380795
Compare
h4sh3d
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.