chore: remove instruction module #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same rationale as bundles, instructions are node specific and doesn't need to be part of core. It is easier to handle them directly into the node. They are currently not used at all so it is not a breaking change to remove them.
h4sh3d
force-pushed
the
remove/instructions
branch
from
eb5c3d5 to
78ce309
Compare
TheCharlatan
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #255. Fix #253
Same rationale as bundles, instructions are node specific and doesn't need to be part of core. It is easier to handle them directly into the node.
They are currently not used at all so it is not a breaking change to remove them.