Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define concrete types in btcxmr modules #273

Merged
merged 1 commit into from
Jul 13, 2022
Merged

feat: define concrete types in btcxmr modules #273

merged 1 commit into from
Jul 13, 2022

Conversation

h4sh3d
Copy link
Member

@h4sh3d h4sh3d commented Jul 13, 2022

Each swap-pair module should export fully defined types based on generic ones in root modules.

@h4sh3d h4sh3d added the enhancement New feature or request label Jul 13, 2022
@h4sh3d h4sh3d added this to the v0.5.0 milestone Jul 13, 2022
TheCharlatan
TheCharlatan approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@TheCharlatan TheCharlatan merged commit 1c86a65 into farcaster-project:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCharlatan TheCharlatan TheCharlatan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@h4sh3d @TheCharlatan