cli: add command to list PublicOffer

[Lederstrumpf]

Lists public offer ids. First step towards addressing #287.
Requires merge of farcaster-project/farcaster-core#195.

[codecov-commenter]

Codecov Report

Merging #303 (e36d527) into main (ef19c74) will increase coverage by 0.0%.
The diff coverage is 22.2%.

@@          Coverage Diff          @@
##            main    #303   +/-   ##
=====================================
  Coverage   15.2%   15.2%           
=====================================
  Files         27      27           
  Lines       6587    6604   +17     
=====================================
+ Hits        1004    1007    +3     
- Misses      5583    5597   +14     

Impacted Files	Coverage Δ
src/cli/command.rs	32.7% <0.0%> (-0.9%)	⬇️
src/farcasterd/runtime.rs	0.0% <0.0%> (ø)
src/rpc/request.rs	16.2% <50.0%> (+0.4%)	⬆️
src/cli/opts.rs	52.6% <66.7%> (-0.1%)	⬇️
src/lib.rs	13.1% <0.0%> (-<0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef19c74...e36d527. Read the comment docs.

[h4sh3d]

Do you need something else in core for this? Otherwise you can release 0.4.3 with the CI

[zkao]

the public offers are in info, you can check how its done there

[zkao]

farcaster-node/src/farcasterd/runtime.rs

Line 634 in 13529be

offers: self.public_offers.iter().cloned().collect(),

[Lederstrumpf]

I've comment the list-offer-ids command for now since we're just pushing the full list of public offers for the PoC and not doing any diffing. Long-term, we should switch to pushing just the IDs since they're more compact and then have the receiver request the base58 encoded offers for anything they're missing.

So now the CLI has only list-swaps and list-offers, where list-offers dumps the public offers as in

farcaster-node/src/farcasterd/runtime.rs

Line 634 in 13529be

offers: self.public_offers.iter().cloned().collect(),

[h4sh3d]

tACK 42fe818

[zkao]

@Lederstrumpf, @h4sh3d can we call swap-cli ls still?

if not can u add that?

[h4sh3d]

@Lederstrumpf maybe there is some sort of "alias" in clap you can use to make list-swaps also respond on ls

[zkao]

yes, its called short

[zkao]

can u please fix that and rebase?

[zkao]

@h4sh3d

[h4sh3d]

Now we can use ls, ls-swaps and list-swaps or ls-offers and list-offers.

[zkao]

ls, ls-swaps and list-swaps or ls-offers and list-offers

there is mixed semantics here: either ls means list or list-swaps, but not both in different contexts

[zkao]

ls --swaps
ls --offers

or

ls-swaps
ls-offers

or

ls
lo

I prefer the latter, because the gain in characters are minimal in the others