fix: optimize state changes order in _unsafeTransfer #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder state changes in _unsafeTransfer function to follow best practices:
This change helps prevent potential reentrancy issues and provides clearer state transition.
PR-Codex overview
This PR focuses on modifying the
_unsafeTransfer
function in theIdRegistry
contract to ensure proper handling of theidOf
mapping during token transfers.Detailed summary
delete idOf[from];
to remove the ID associated with thefrom
address before transferring.idOf[to] = id;
to assign the ID to theto
address.Transfer
event after the ID transfer.