-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for user location in the protocol #2365
feat: add support for user location in the protocol #2365
Conversation
🦋 Changeset detectedLatest commit: ebe9b0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
===========================================
- Coverage 74.05% 44.19% -29.86%
===========================================
Files 99 146 +47
Lines 9425 26195 +16770
Branches 2097 9301 +7204
===========================================
+ Hits 6980 11578 +4598
- Misses 2327 12783 +10456
- Partials 118 1834 +1716 ☔ View full report in Codecov by Sentry. |
This is required to decentralize user location.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR introduces a new feature to add user location data to the protocol, including validation for latitude and longitude, and updates across several files to support this functionality.
Detailed summary
USER_DATA_TYPE_LOCATION
toprotobufs/schemas/message.proto
.userDataTypeFromJSON
anduserDataTypeToJSON
functions to handle location type.packages/hub-web
,packages/hub-nodejs
, andpackages/core
.apps/hubble/src/rpc/test/userDataService.test.ts
andpackages/core/src/validations.test.ts
.