Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for user location in the protocol #2365

Merged
merged 9 commits into from
Oct 12, 2024

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Oct 11, 2024

This is required to decentralize user location.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces a new feature to add user location data to the protocol, including validation for latitude and longitude, and updates across several files to support this functionality.

Detailed summary

  • Added USER_DATA_TYPE_LOCATION to protobufs/schemas/message.proto.
  • Updated userDataTypeFromJSON and userDataTypeToJSON functions to handle location type.
  • Implemented location handling in packages/hub-web, packages/hub-nodejs, and packages/core.
  • Created validation functions for latitude and longitude.
  • Added tests for user location data handling in apps/hubble/src/rpc/test/userDataService.test.ts and packages/core/src/validations.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: ebe9b0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/core Patch
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 9:49pm

@aditiharini aditiharini added the t-feat Add a new feature or protocol improvement label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 15 lines in your changes missing coverage. Please review.

Project coverage is 44.19%. Comparing base (1880070) to head (ebe9b0b).
Report is 399 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/protobufs/generated/message.ts 0.00% 5 Missing ⚠️
packages/core/src/validations.ts 87.80% 5 Missing ⚠️
packages/hub-nodejs/src/generated/message.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2365       +/-   ##
===========================================
- Coverage   74.05%   44.19%   -29.86%     
===========================================
  Files          99      146       +47     
  Lines        9425    26195    +16770     
  Branches     2097     9301     +7204     
===========================================
+ Hits         6980    11578     +4598     
- Misses       2327    12783    +10456     
- Partials      118     1834     +1716     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini merged commit aa9cde7 into farcasterxyz:main Oct 12, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants