Implemented missing Get... RPCs(GetCastsByMention) in rpc.proto and server.rs issue #189 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edited get_casts_by_mention to support the get_casts_by_mention in server.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses issue #189: "Implement the remaining read APIs."
The following updates were made to achieve parity with the Get... RPCs in the existing hubs:
rpc GetCastsByMention(FidRequest) returns (MessagesResponse);Changes Made:
Updated rpc.proto:
-Added definitions for the missing Get... RPCs, following the existing style and structure:
rpc GetCastsByMention(FidRequest) returns (MessagesResponse);Updated server.rs:
Implemented the server-side logic for handling the new Get... RPCs, specifically
get_casts_by_mentionReused or adapted existing utility functions to minimize duplication and maintain clean code.
How It Solves the Issue:
These changes bring the Get... RPCs in snapchain to parity with those in the original hubs project, ensuring compatibility and feature completeness.
Checklist:
Added missing Get... RPCs to rpc.proto: rpc GetCastsByMention(FidRequest) returns (MessagesResponse);
Implemented Get... RPC logic in server.rs: get_casts_by_mention
Verified with unit and integration tests.
Reviewed for code quality and adherence to project guidelines.
References:
Issue Link: #189