fix: import/export minify duplicate identifier #1625

.changeset/afraid-poems-search.md

@@ -0,0 +1,5 @@
+---
+"@farmfe/core": patch
+---
+
+Fix import/export minify #1625

crates/core/src/config/minify.rs

@@ -13,7 +13,7 @@ pub enum MinifyMode {
 }
 
 #[derive(Debug, Clone, Deserialize, Serialize)]
-#[serde(default)]
+#[serde(default, rename_all = "camelCase")]
 pub struct MinifyOptions {
   pub compress: BoolOrObj<Value>,
   pub mangle: BoolOrObj<Value>,
@@ -59,7 +59,9 @@ impl From<&BoolOrObj<Value>> for Option<MinifyOptions> {
   }
 }
 
+#[cfg(test)]
 mod tests {
+  use crate::config::minify::MinifyMode;
 
   #[test]
   fn deserialize_minify_mode() {
@@ -99,10 +101,20 @@ mod tests {
       "include": ["@farmfe/runtime"],
       "exclude": ["node_modules/"],
       "mode": "minify-resource-pot",
+      "moduleDecls": false,
     });
     let minify =
       BoolOrObj::Obj(options).map(|val| serde_json::from_value::<MinifyOptions>(val).unwrap());
 
-    assert!(matches!(minify, BoolOrObj::Obj(MinifyOptions { .. })));
+    assert!(matches!(
+      minify,
+      BoolOrObj::Obj(MinifyOptions {
+        compress: BoolOrObj::Bool(true),
+        mangle: BoolOrObj::Bool(true),
+        mode: MinifyMode::ResourcePot,
+        module_decls: false,
+        ..
+      })
+    ));
   }
 }

crates/plugin_minify/src/imports_minifier.rs

@@ -80,7 +80,7 @@ impl<'a> ImportsMinifier<'a> {
       used_ident = format!("{}{}", ident, count);
     }
 
-    self.inc_exported_ident_count(used_ident.clone());
+    self.inc_imported_ident_count(used_ident.clone());
 
     used_ident
   }
@@ -207,7 +207,7 @@ impl<'a> VisitMut for ImportsMinifier<'a> {
                   }
 
                   for ident in ident_to_inc {
-                    self.inc_imported_ident_count(ident.clone());
+                    self.inc_imported_ident_count(ident);
                   }
                 }
                 farmfe_core::swc_ecma_ast::ImportSpecifier::Default(default) => {