Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: websocket and devserver #700

Merged
merged 21 commits into from
Nov 6, 2023
Merged

refactor: websocket and devserver #700

merged 21 commits into from
Nov 6, 2023

Conversation

ErKeLost
Copy link
Member

@ErKeLost ErKeLost commented Nov 2, 2023 •
edited
Loading

Description:

  1. Decimate websocket logic with class.
  2. Expose more api.
  3. Merge to the vite devserver api plugin

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd6cbb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ErKeLost ErKeLost changed the title refactor(WIP): websocket refactor: websocket and devserver Nov 4, 2023
wre232114
wre232114 reviewed Nov 5, 2023
View reviewed changes
packages/runtime-plugin-hmr/src/index.ts Outdated Show resolved Hide resolved
packages/core/src/server/test/index.html Outdated Show resolved Hide resolved
@ErKeLost ErKeLost merged commit 032a05d into main Nov 6, 2023
30 of 31 checks passed
@ErKeLost ErKeLost deleted the refactor/websocket branch November 6, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wre232114 wre232114 wre232114 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErKeLost @wre232114