-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAI-13445: Have all converters writing geo_location use shared utility #1754
Conversation
Signed-off-by: Chalenge Masekera <5385518+chalenge@users.noreply.github.com>
@@ -4,8 +4,8 @@ exports[`bamboohr process records from all streams 1`] = ` | |||
Array [ | |||
"Processed 87 records", | |||
"Processed records by stream: {\\\\\\"mytestsource__bamboohr__users\\\\\\":87}\\"},\\"type\\":\\"LOG\\"}", | |||
"Would write 493 records", | |||
"Would write records by model: {\\\\\\"geo_Address\\\\\\":87,\\\\\\"geo_Location\\\\\\":87,\\\\\\"identity_Identity\\\\\\":87,\\\\\\"org_Department\\\\\\":9,\\\\\\"org_Employee\\\\\\":87,\\\\\\"org_Team\\\\\\":26,\\\\\\"org_TeamMembership\\\\\\":110}\\"},\\"type\\":\\"LOG\\"}", | |||
"Would write 371 records", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we were writing duplicate records hence reduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
There's a failing test that checks the dest spec. You're adding to it so that's expected. Just need to check whether the spec looks good ( |
I always forget this test 😫 |
Signed-off-by: Chalenge Masekera <5385518+chalenge@users.noreply.github.com>
Quality Gate passedIssues Measures |
Description
Type of change