FAI-13445: Have all converters writing geo_location use shared utility #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chalenge Masekera <5385518+chalenge@users.noreply.github.com>
chalenge
requested review from
cjwooo,
ypc-faros and
willmarks
as code owners
chalenge
commented
Oct 23, 2024
| @@ -4,8 +4,8 @@ exports[`bamboohr process records from all streams 1`] = ` | |||
| Array [ | |||
| "Processed 87 records", | |||
| "Processed records by stream: {\\\\\\"mytestsource__bamboohr__users\\\\\\":87}\\"},\\"type\\":\\"LOG\\"}", | |||
| "Would write 493 records", | |||
| "Would write records by model: {\\\\\\"geo_Address\\\\\\":87,\\\\\\"geo_Location\\\\\\":87,\\\\\\"identity_Identity\\\\\\":87,\\\\\\"org_Department\\\\\\":9,\\\\\\"org_Employee\\\\\\":87,\\\\\\"org_Team\\\\\\":26,\\\\\\"org_TeamMembership\\\\\\":110}\\"},\\"type\\":\\"LOG\\"}", | |||
| "Would write 371 records", | |||
There was a problem hiding this comment.
we were writing duplicate records hence reduction
|
There's a failing test that checks the dest spec. You're adding to it so that's expected. Just need to check whether the spec looks good ( |
I always forget this test 😫 |
Signed-off-by: Chalenge Masekera <5385518+chalenge@users.noreply.github.com>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change