Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAI-13600 | Add retries for 422 error on PR files API (GitHub) #1755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FAI-13600 | Add retries for 422 error on PR files API (GitHub) #1755

wants to merge 1 commit into from

Conversation

dbruno21
Copy link
Contributor

@dbruno21 dbruno21 commented Oct 25, 2024 •
edited
Loading

Description

Add retries for 422 error on PR files API (GitHub)

  • Added custom plugin / hook because retries plugin doNotRetry parameter is fixed after initializing Octokit instance (#1 #2) and to avoid having to do retry logic manually.

Type of change

  • Bug fix
  • New feature
  • Breaking change

Related issues

Fix #1

Migration notes

Describe migration notes if any

Extra info

Add any additional information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbruno21 dbruno21 marked this pull request as ready for review October 25, 2024 21:19
ypc-faros
ypc-faros reviewed Oct 26, 2024
View reviewed changes
sources/github-source/src/octokit.ts
throw new RequestError(
`GitHub request timed-out after ${timeoutMs} ms`,
500,
1000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this 1000 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypc-faros ypc-faros ypc-faros left review comments

@cjwooo cjwooo Awaiting requested review from cjwooo cjwooo is a code owner

@willmarks willmarks Awaiting requested review from willmarks willmarks is a code owner

@chalenge chalenge Awaiting requested review from chalenge

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbruno21 @ypc-faros