Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set additionalProperties: true #588

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Set additionalProperties: true #588

merged 1 commit into from
Jul 27, 2022

Conversation

cjwooo
Copy link
Contributor

@cjwooo cjwooo commented Jul 27, 2022

Description

Airbyte now requires additionalProperties = true in JSON schemas. airbytehq/airbyte#14196

Type of change

  • Bug fix
  • New feature
  • Breaking change

Related issues

Fix #1

Migration notes

Describe migration notes if any

Extra info

Add any additional information

Copy link
Contributor

@willmarks willmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this changed

@cjwooo
Copy link
Contributor Author

cjwooo commented Jul 27, 2022

This change was implemented as part of resolving one of their oncall issues.

@cjwooo cjwooo merged commit ad08d67 into main Jul 27, 2022
@cjwooo cjwooo deleted the cwu/sat branch July 27, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants