Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util module is not ideal for tool packaging #122

Closed
pemensik opened this issue Nov 8, 2024 · 0 comments · Fixed by #123
Closed

util module is not ideal for tool packaging #122

pemensik opened this issue Nov 8, 2024 · 0 comments · Fixed by #123
Assignees

Comments

@pemensik
Copy link
Contributor

pemensik commented Nov 8, 2024

Could you rename util ti dnsdiag module instead? I would like to package this project into Fedora, but util module does not seem ideal from distribution perspective.

It would place util into path:

/usr/lib/python3.13/site-packages/util/dns.py
/usr/lib/python3.13/site-packages/util/shared.py
/usr/lib/python3.13/site-packages/util/whois.py

But the name is generic and nonspecific, while the content is specific to this package. I think it should import its constants either from dnsdiag.util or just dnsdiag module.

pemensik added a commit to pemensik/dnsdiag that referenced this issue Nov 8, 2024
util is too generic to be used as shared module.

Fixes farrokhi#122
@farrokhi farrokhi self-assigned this Nov 8, 2024
farrokhi pushed a commit that referenced this issue Nov 8, 2024
util is too generic to be used as shared module.

Fixes #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants