Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #4623 #4642

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fixed #4623 #4642

merged 2 commits into from
Nov 27, 2024

Conversation

knighthat
Copy link

I put a condition to remove explicit prefix during sort to make it more accurate.

Question

Why are we using prefixes instead of having a boolean column for these? For example

From

songId title artistsText durationText thumbnailUrl likedAt totalPlayTimeMs
id1 artist title goes here 2:59 https://example.com null 0
id1 artist e:title goes here 2:59 https://example.com null 0
id1 artist e:title goes here 2:59 https://example.com null 0

To

songId title artistsText durationText thumbnailUrl likedAt totalPlayTimeMs isExplicit
id1 artist title goes here 2:59 https://example.com null 0 false
id1 artist title goes here 2:59 https://example.com null 0 true
id1 artist title goes here 2:59 https://example.com null 0 true

@fast4x
Copy link
Owner

fast4x commented Nov 25, 2024

Because i don't want to modify db structure.

@fast4x
Copy link
Owner

fast4x commented Nov 26, 2024

Why have removed @SuppressWarnings(RoomWarnings.QUERY_MISMATCH)

@knighthat
Copy link
Author

Is it throwing error or something?

It ready returns all columns from Song table as Song object and the other 2 are indicated in @Query?

Or am I mistaken here?

I think there's @Embeded to add to Song in SongEntity to remove the warning

@fast4x
Copy link
Owner

fast4x commented Nov 26, 2024

It remove warning for non all fields from SongEntity was returned

@fast4x
Copy link
Owner

fast4x commented Nov 26, 2024

Is it throwing error or something?

It ready returns all columns from Song table as Song object and the other 2 are indicated in @Query?

Or am I mistaken here?

I think there's @Embeded to add to Song in SongEntity to remove the warning

Song have just embedded song...

@knighthat
Copy link
Author

yes, that's what I was talking about. The only column's missing form the query is contentLength, do you want me too make it null or fetch from Format?

@fast4x
Copy link
Owner

fast4x commented Nov 26, 2024

Fetch from format it's a good idea

@knighthat
Copy link
Author

K, expect new commit(s) in a few hrs

@knighthat
Copy link
Author

Done, contentLength from Format table is now a part of the result

@fast4x
Copy link
Owner

fast4x commented Nov 27, 2024

Nice thanks

@fast4x fast4x merged commit bbd7e9d into fast4x:master Nov 27, 2024
@knighthat knighthat deleted the issue-4623 branch November 27, 2024 17:39
@knighthat knighthat mentioned this pull request Dec 7, 2024
fast4x added a commit that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants