Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a way for user to choose the duration after which the current track will restart after pressing the previous button #4677

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

aneesh1122
Copy link

Check for any bugs. I couldn't find any

…rent track will restart after pressing the previous button
@@ -346,6 +348,8 @@ fun ControlsEssential(

var queueLoopType by rememberPreference(queueLoopTypeKey, defaultValue = QueueLoopType.Default)
val playerBackgroundColors by rememberPreference(playerBackgroundColorsKey,PlayerBackgroundColors.BlurredCoverColor)
var jumpPrevious by rememberPreference(jumpPreviousKey,"3")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a text field if after convert in toInt()... use directly int...

Copy link
Author

@aneesh1122 aneesh1122 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integer type can't be blank and while entering the value in the text field if the text is empty it will throw errors.

So I'm using string and converting it to integer later so that the text field can be empty.

I'm doing what I did before for mini queue

Pls improve it the way you want

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ok, in the future if necessary.

@fast4x fast4x merged commit 304b9b8 into fast4x:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants