Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some problems of downloaded tab and caches #5020

Merged
merged 6 commits into from
Dec 22, 2024

Conversation

twistios
Copy link

@twistios twistios commented Dec 21, 2024

  • also now hidden downloaded songs are now always shown
  • downloaded songs are now also removed from Download manager (previously was not so when deleting all via data settings, deleted downloads where still shown as downloaded but are actually not)

- also now hidden downloaded songs are now alway shown
- deleted songs where still shows as downloaded even if the song-data itself was already deleted
@twistios
Copy link
Author

Current problems:

  • Eye icon is still there for downloads tab
  • downloads storage usage does not update after deleting all downloaded songs (if one does not exist the menu first)

@twistios
Copy link
Author

twistios commented Dec 21, 2024

downloads storage usage does not update after deleting all downloaded songs (if one does not exist the menu first)

This can be easily fixed, but not fully. Because the "deleted" state does not get reset, so it can happen only once while in that menu

EDIT: ok, I was wrong, it seems to work multiple times.

@twistios
Copy link
Author

Another problem is that the number potentially does not update, if it is changed by new data.

@twistios
Copy link
Author

Another problem is that the number potentially does not update, if it is changed by new data.

Solved

@twistios twistios changed the title fixed some problems of downloaded tab fixed some problems of downloaded tab and caches Dec 21, 2024
@twistios
Copy link
Author

Eye problem remains, but otherwise these changes should be ok. Hope it does not break with the other changes.

@twistios twistios marked this pull request as ready for review December 21, 2024 23:02
@fast4x fast4x merged commit 3127450 into fast4x:master Dec 22, 2024
@fast4x
Copy link
Owner

fast4x commented Dec 22, 2024

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants