Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running nbdev_migrate while upgrading removes nbdev2 compatible directives #1089

Closed
warner-benjamin opened this issue Sep 18, 2022 · 1 comment
Closed

Running nbdev_migrate while upgrading removes nbdev2 compatible directives #1089

warner-benjamin opened this issue Sep 18, 2022 · 1 comment
Assignees
@hamelsmu
Labels
bug Something isn't working

Comments

@warner-benjamin
Copy link

While following the migration tutorial using the latest nbdev 2.3.5 release, running the nbdev_migrate command in the library root folder removed all directives which I had previously updated to be nbdev2 compatible.

For example, existing #|export directives were completely removed and #export modified to #|export.

Expectation: properly formatted nbdev2 directives would be untouched and nbdev_migrate would only modify old style nbdev1 directives.
@warner-benjamin warner-benjamin changed the title Running nbdev_migrate on a nbdev1 library removed all nbdev2 compatible directives Running nbdev_migrate while upgrading nbdev1 library removed all nbdev2 compatible directives Sep 18, 2022
@jph00 jph00 changed the title Running nbdev_migrate while upgrading nbdev1 library removed all nbdev2 compatible directives Running nbdev_migrate while upgrading removes nbdev2 compatible directives Sep 18, 2022
@jph00 jph00 added the bug Something isn't working label Sep 18, 2022
@hamelsmu
Copy link
Member

Thanks, fixing this with #1096

hamelsmu added a commit that referenced this issue Sep 19, 2022
@hamelsmu
Merge pull request #1096 from fastai/migrate-fix
d26ce6e 
fix #1089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamelsmu hamelsmu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jph00 @hamelsmu @warner-benjamin