-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starlette's TestClient unused #111
Comments
Not the author/maintainer, so I can't say with authority, but PRs are probably welcome. :-) |
I suppose so, but before I create the PR, I would like to know this 😄:
|
My understanding is that all of the @tiangolo cookie-cutter repos are ideally kept in "sync" as much as possible. So modifying the tests for the full-stack repo means modifying tests on all of the other FastAPI cookie-cutters. But that doesn't mean a PR isn't welcome to start that process and let others see how you've implemented @Toreno96 ! This would be very useful 😄 |
Thanks for the help here everyone! So, yes, I would like to have the tests using the It is set up this way because this project generator inherited a lot of the code from my previous project generator for Flask (predating FastAPI). |
I believe this is fully addressed by #160 and can be closed. |
That's true, thanks for the reminder. I'm closing the issue. |
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hi,
The official FastAPI's tutorial recommends to use Starlette's TestClient in testing.
Why this project template is inconsistent with the above? Was there any specific design decision to omit TestClient in the backend tests and use
Requests
instead? 🤔I made a fork where I successfully integrated TestClient, so if you want I will create PR.
The text was updated successfully, but these errors were encountered: