-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing_extensions dep. #507
Conversation
📝 Docs preview for commit 7320fc5 at: https://63767105747f9411682c20d3--typertiangolo.netlify.app |
📝 Docs preview for commit b4b07eb at: https://639ce9d92c118d0a1647f762--typertiangolo.netlify.app |
@tiangolo Let me know if there is anything more I can add/test/show here to help. |
@tiangolo adding a repro to demonstrate the issue, would be great if we could merge. Let me know if there is anything else I can do to help, test, etc.
If you update the version of |
Thanks @ryangalamb, looks like your PR got merged so this can be closed. |
Currently, when running on older versions of python before 3.8, Typer requires the use of typing_extensions for the
Literal
type.https://github.com/tiangolo/typer/blob/6208b5b2087d3474023cdf650a246c9a6c8327c3/typer/core.py#L30-L33
This was added to that library after typing_extensions 3.6.6 release (diff here).
When I run on python3.7 I'm seeing issues when testing my typer clis due to this missing dep.
I'm not the most familiar with the python packaging ecosystem but I pulled the syntax from here:
https://flit.pypa.io/en/stable/pyproject_toml.html#dependencies