Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy to 1.0.1 & remove Python 3.6 support #556

Closed
wants to merge 3 commits into from

Conversation

jonaslb
Copy link
Contributor

@jonaslb jonaslb commented Feb 17, 2023

This bumps mypy and fixes necessary minor things that turned up as a conseqence of it.

Related to #548 where I couldn't really find a solution that worked with the old mypy, but when I fixed it to work with a newer mypy I didn't realize it was pinned (which makes sense). But anyway this mypy update should make the other PR pass tests...

@github-actions
Copy link

📝 Docs preview for commit 698baac at: https://63efaf3498164f0343350c32--typertiangolo.netlify.app

@jonaslb
Copy link
Contributor Author

jonaslb commented Feb 17, 2023

Ah, looks like mypy has dropped Python 3.6, so it won't work with the tests there.... Maybe I will look into making typer drop 3.6 then.

Entailed a pyupgrade run which pretty much only resulted in a few more
f-strings.

Also remove all mentions of 3.6 in the docs, scripts etc.
This more or less was a "find and replace" operation. That means some
"example output" with python versions was also adapted. That output
should probably be "completely" updated, but for now, I thought it
shouldn't say anything about Python 3.6 when typer no longer supports
it.
@jonaslb jonaslb changed the title Bump mypy to 1.0.1 Bump mypy to 1.0.1 & remove Python 3.6 support Feb 17, 2023
@github-actions
Copy link

📝 Docs preview for commit d5ee47a at: https://63efb3cd959a34051743eee4--typertiangolo.netlify.app

@jonaslb
Copy link
Contributor Author

jonaslb commented Feb 17, 2023

That's it, although now there are two topics in the PR, they are in separate commits and overall the changes are still minor.

@kudlatyamroth
Copy link

Ah, looks like mypy has dropped Python 3.6, so it won't work with the tests there.... Maybe I will look into making typer drop 3.6 then.

Click drop support for 3.6 in 8.1 version ( https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0 )
so Typer also not support it :)

@svlandeg svlandeg added dependencies Pull requests that update a dependency file p3 labels Mar 1, 2024
@svlandeg
Copy link
Member

Maybe I will look into making typer drop 3.6 then.

Hi! Note that Python 3.6 support was recently dropped in 0.11.0.

@jonaslb
Copy link
Contributor Author

jonaslb commented Mar 29, 2024

Yeah looks like this has been long superseded by other changes, so closing.

@jonaslb jonaslb closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file p3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants