-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mypy to 1.0.1 & remove Python 3.6 support #556
Conversation
📝 Docs preview for commit 698baac at: https://63efaf3498164f0343350c32--typertiangolo.netlify.app |
Ah, looks like mypy has dropped Python 3.6, so it won't work with the tests there.... Maybe I will look into making typer drop 3.6 then. |
Entailed a pyupgrade run which pretty much only resulted in a few more f-strings. Also remove all mentions of 3.6 in the docs, scripts etc. This more or less was a "find and replace" operation. That means some "example output" with python versions was also adapted. That output should probably be "completely" updated, but for now, I thought it shouldn't say anything about Python 3.6 when typer no longer supports it.
📝 Docs preview for commit d5ee47a at: https://63efb3cd959a34051743eee4--typertiangolo.netlify.app |
That's it, although now there are two topics in the PR, they are in separate commits and overall the changes are still minor. |
Click drop support for 3.6 in 8.1 version ( https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0 ) |
Hi! Note that Python 3.6 support was recently dropped in 0.11.0. |
Yeah looks like this has been long superseded by other changes, so closing. |
This bumps mypy and fixes necessary minor things that turned up as a conseqence of it.
Related to #548 where I couldn't really find a solution that worked with the old mypy, but when I fixed it to work with a newer mypy I didn't realize it was pinned (which makes sense). But anyway this mypy update should make the other PR pass tests...