✨ Render Rich markup as HTML in Markdown docs #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
commented
May 28, 2024
svlandeg
changed the title
7 tasks
|
Just for completeness, extra info: I'm not sure what changed, maybe it was something in a recent release in Rich, because tests were passing here before merging, but then they were no longer passing 😅 I changed it here: #1055, it was about how to capture and render the Rich console. |
masenf
added a commit
to reflex-dev/reflex
that referenced
this pull request
Nov 21, 2024
The `rich` module should be set to `None`, indicating that rich should not be used. Setting it to `False` worked before, but recently added code in typer fails when checking `if rich is not None`. ref: fastapi/typer#847
masenf
added a commit
to reflex-dev/reflex
that referenced
this pull request
Nov 21, 2024
The `rich` module should be set to `None`, indicating that rich should not be used. Setting it to `False` worked before, but recently added code in typer fails when checking `if rich is not None`. ref: fastapi/typer#847
Lendemor
pushed a commit
to reflex-dev/reflex
that referenced
this pull request
Nov 21, 2024
The `rich` module should be set to `None`, indicating that rich should not be used. Setting it to `False` worked before, but recently added code in typer fails when checking `if rich is not None`. ref: fastapi/typer#847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819: ensure that Rich-formatted help texts get rendered properly in Markdown by using the Rich built-in
export_htmlfunctionality.I've expanded the example from #819 to ensure that the following are covered: Command help, Option help, Argument help, default value,
[required]flag.TODO
Double check whether existing functionality and printing behaviour has remained unchanged.