Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display: capitalize {type}'s output #1543

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Conversation

zhon12345
Copy link
Contributor

Before:
image

After:
image

I'm not sure if there's a bug in the dev branch or I'm just missing dependencies. The resolution is wrong and there's no primary detection

@CarterLi
Copy link
Member

CarterLi commented Feb 7, 2025

fastfetch -s display --format json on dev branch?

@zhon12345
Copy link
Contributor Author

dev branch:
╰─❯❯❯ ~/Documents/Github/fastfetch/build/fastfetch -s display --format json

[
	{
		"type": "Display",
		"result": [
			{
				"id": 0,
				"name": "2D HD LG TV",
				"primary": false,
				"output": {
					"width": 1366,
					"height": 768,
					"refreshRate": 59.78954081632653
				},
				"scaled": {
					"width": 0,
					"height": 0
				},
				"preferred": {
					"width": 0,
					"height": 0,
					"refreshRate": 0.0
				},
				"physical": {
					"width": 521,
					"height": 293
				},
				"rotation": 0,
				"bitDepth": 0,
				"hdrStatus": "Unsupported",
				"type": "External",
				"manufactureDate": {
					"year": 2019,
					"week": 1
				},
				"serial": 16843009,
				"platformApi": "sysfs-drm"
			},
			{
				"id": 0,
				"name": "AUO313C",
				"primary": false,
				"output": {
					"width": 1366,
					"height": 768,
					"refreshRate": 60.098446979814554
				},
				"scaled": {
					"width": 0,
					"height": 0
				},
				"preferred": {
					"width": 0,
					"height": 0,
					"refreshRate": 0.0
				},
				"physical": {
					"width": 309,
					"height": 173
				},
				"rotation": 0,
				"bitDepth": 0,
				"hdrStatus": "Unsupported",
				"type": "Builtin",
				"manufactureDate": {
					"year": 2010,
					"week": 0
				},
				"serial": null,
				"platformApi": "sysfs-drm"
			}
		]
	}
]

installed with zypper:
╰─❯❯❯ fastfetch -s display --format json

[
	{
		"type": "Display",
		"result": [
			{
				"id": 3543560144569582664,
				"name": "2D HD LG TV",
				"primary": true,
				"output": {
					"width": 1920,
					"height": 1080,
					"refreshRate": 60.0
				},
				"scaled": {
					"width": 1920,
					"height": 1080
				},
				"preferred": {
					"width": 1366,
					"height": 768,
					"refreshRate": 59.79
				},
				"physical": {
					"width": 521,
					"height": 293
				},
				"rotation": 0,
				"bitDepth": 0,
				"hdrStatus": "Unsupported",
				"type": "External",
				"manufactureDate": {
					"year": 2019,
					"week": 1
				},
				"serial": 16843009,
				"platformApi": "wayland-kde"
			},
			{
				"id": 211213632613,
				"name": "AUO313C",
				"primary": false,
				"output": {
					"width": 1366,
					"height": 768,
					"refreshRate": 60.098
				},
				"scaled": {
					"width": 1366,
					"height": 768
				},
				"preferred": {
					"width": 1366,
					"height": 768,
					"refreshRate": 60.098
				},
				"physical": {
					"width": 309,
					"height": 173
				},
				"rotation": 0,
				"bitDepth": 0,
				"hdrStatus": "Unsupported",
				"type": "Builtin",
				"manufactureDate": {
					"year": 2010,
					"week": 0
				},
				"serial": null,
				"platformApi": "wayland-kde"
			}
		]
	}
]

@CarterLi
Copy link
Member

CarterLi commented Feb 7, 2025

It suggests that you were missing build dependencies. It should be ok to ignore the error.

@CarterLi CarterLi merged commit 292fa06 into fastfetch-cli:dev Feb 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants