Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip macos-latest for Node.js v14 and v16 in the 3.x line #37

Closed
mcollina opened this issue Apr 28, 2024 · 3 comments
Closed

Skip macos-latest for Node.js v14 and v16 in the 3.x line #37

mcollina opened this issue Apr 28, 2024 · 3 comments

Comments

@mcollina
Copy link
Member

GHA updated macos-latest to be an ARM platform. However this broke all our CI runs for all plugins because there are no arm build for Node v14 and v16.

The solution is to skip macos-latest and those versions of Node.js everywhere in the 3.x line (which is what we use everywhere).

@mcollina
Copy link
Member Author

mcollina commented Apr 28, 2024

cc @simoneb @Eomm @Fdawgs

simoneb added a commit to fastify/workflows that referenced this issue Apr 28, 2024
Related to fastify/.github#37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

Signed-off-by: Simone Busoli <simone.busoli@gmail.com>
@simoneb
Copy link

simoneb commented Apr 28, 2024

Sent a proposed change here, check it out fastify/workflows#127

mcollina pushed a commit to fastify/workflows that referenced this issue Apr 29, 2024
* chore: exclude Node 14 and 16 on macos

Related to fastify/.github#37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

Signed-off-by: Simone Busoli <simone.busoli@gmail.com>

* remove os matrix from package

---------

Signed-off-by: Simone Busoli <simone.busoli@gmail.com>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
gurgunday added a commit to gurgunday/workflows that referenced this issue Apr 29, 2024
* chore: exclude Node 14 and 16 on macos

Related to fastify/.github#37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

Signed-off-by: Simone Busoli <simone.busoli@gmail.com>

* remove os matrix from package

---------

Signed-off-by: Simone Busoli <simone.busoli@gmail.com>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
gurgunday added a commit to fastify/workflows that referenced this issue Apr 29, 2024
* chore: exclude Node 14 and 16 on macos

Related to fastify/.github#37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations



* remove os matrix from package

---------

Signed-off-by: Simone Busoli <simone.busoli@gmail.com>
@Fdawgs
Copy link
Member

Fdawgs commented May 1, 2024

closed by fastify/workflows#127 and fastify/workflows#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants