Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract noop #215

Closed
wants to merge 2 commits into from
Closed

extract noop #215

wants to merge 2 commits into from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jun 23, 2023

based on #199

Checklist

Eomm
Eomm reviewed Jun 24, 2023
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this optimization? 😅

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jun 24, 2023

just reordering stuff.

mcollina
mcollina requested changes Jun 24, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually better not to do this from a perf perspective. V8 optimizes noop in the same file better (or used to).

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jun 24, 2023

Ok ;)

@Uzlopak Uzlopak closed this Jun 24, 2023
@Uzlopak Uzlopak deleted the extract-noop branch June 24, 2023 21:44
@Uzlopak Uzlopak mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @mcollina @Eomm