Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fieldNameSize for multipart #57

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 2, 2021

This PR is not ready for merge.

Discussion-points

  • Currently it checks for specific rfc-relevant fieldNames and does not apply fieldNameSize on those fieldnames. Should we remove that and just write in the documentation, that we recommend not to limit the fieldNameSize to some unreasonable value? If so it would remove this check for the specific fieldnames and in real world use cases you want to limit the fieldNameSize to something like 255 characters and not 3.
  • I assume that like in the added unit test, that "test" is a value and not a key so it should apply the fieldSize instead of the fieldNameSize, right?

Checklist

@Uzlopak Uzlopak requested a review from kibertoad December 2, 2021 14:57
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 2, 2021

Actually multipart seems to not respect fieldSize either.

@Uzlopak Uzlopak changed the title add initial commit for fieldNameSize for multipart add fieldNameSize for multipart Dec 2, 2021
@Uzlopak Uzlopak marked this pull request as draft December 4, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant