Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the security implication of using this module in the README #34

Merged
merged 6 commits into from
Jan 21, 2021

Conversation

mcollina
Copy link
Member

As title, let's make it clearer what the responsibilities of this plugin are.

Checklist

README.md Outdated Show resolved Hide resolved
Co-authored-by: Simone Busoli <simone.busoli@gmail.com>
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few tweaks as suggested

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mcollina and others added 4 commits January 21, 2021 14:52
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
@mcollina mcollina merged commit a31f886 into master Jan 21, 2021
@mcollina mcollina deleted the update-readmewq branch January 21, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants