Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(equal): refactor test suites #45

Merged
merged 1 commit into from
Jun 19, 2022
Merged

test(equal): refactor test suites #45

merged 1 commit into from
Jun 19, 2022

Conversation

zekth
Copy link
Member

@zekth zekth commented Jun 19, 2022 •
edited
Loading

Ensure we test parameters the same way.

Checklist

@zekth zekth marked this pull request as ready for review June 19, 2022 09:11
@zekth zekth requested a review from Eomm June 19, 2022 10:04
mcollina
mcollina approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 8969aa1 into main Jun 19, 2022
@zekth zekth deleted the test-equals branch June 19, 2022 14:36
@X-oss-byte X-oss-byte mentioned this pull request Jul 5, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zekth @mcollina @Eomm