Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix urijs fragment handling incompatibility #93

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Jun 26, 2024

This fixes the fragment issue that breaks the Ajv integration

The reason for this one is just not fun... caused mainly by uri-js's different encoding and decoding mechanism when the fragment is not a valid URI part

We can trace it back to here: https://github.com/fastify/fast-uri/pull/23/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R280

@gurgunday gurgunday requested review from mcollina, zekth and a team June 26, 2024 12:38
@gurgunday gurgunday merged commit b16b747 into fastify:main Jun 27, 2024
20 checks passed
@gurgunday gurgunday deleted the fix-compat branch June 27, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants