Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tape #95

Merged
merged 6 commits into from
Jun 27, 2024
Merged

use tape #95

merged 6 commits into from
Jun 27, 2024

Conversation

gurgunday
Copy link
Member

I replace-all'd a lot of things so let me know if I missed anything important

@gurgunday gurgunday requested review from mcollina and a team June 27, 2024 11:14
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add back Node.js v16?

@gurgunday
Copy link
Member Author

@gurgunday
Copy link
Member Author

I added node 22

@gurgunday gurgunday requested a review from mcollina June 27, 2024 12:08
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0655453 into fastify:main Jun 27, 2024
22 checks passed
@gurgunday gurgunday deleted the tape branch June 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants